[8.x](backport #5748) Don't run any agent service when running otel subcommand
#5797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove need to run agent while running otel subcommand. * Cleanup. * Fix tests. * Fix tests. * Few more cleanups. * Mage check. (cherry picked from commit 3f1e4da)
blakerouse
approved these changes
Oct 15, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously the control protocol was started when the subcommand
otelwas ran. This should not be done as the subcommandotelshould operate it in a pure OTel mode.This is a cleanup that comes out of working on Hybrid mode.
Why is it important?
Cleanup to make the code cleaner and less messy as the control protocol should not really be running when running the otel subcommand.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog toolDisruptive User Impact
Can no longer call
elastic-agent statuswhen aelastic-agent otelis running.How to test this PR locally
Run
elastic-agent otel, then try to runelastic-agent statusand see that it doesn't connect.This is an automatic backport of pull request #5748 done by [Mergify](https://mergify.com).