Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all Docker images to K8s integration tests #5790

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

rdner
Copy link
Member

@rdner rdner commented Oct 15, 2024

So, we validate all produced images.

Test runtime:

Let me know if the runtime increase is sensible.

So, we validate all produced images.
@rdner rdner added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify labels Oct 15, 2024
@rdner rdner self-assigned this Oct 15, 2024
@rdner rdner linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link

@rdner rdner marked this pull request as ready for review October 15, 2024 16:29
@rdner rdner requested a review from a team as a code owner October 15, 2024 16:29
@rdner rdner requested review from blakerouse and swiatekm October 15, 2024 16:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@rdner rdner requested review from cmacknz and removed request for swiatekm October 15, 2024 16:29
@jlind23
Copy link
Contributor

jlind23 commented Oct 15, 2024

Looks like the overall time is still lower then the integration tests execution time so we should be good on that end.
Starting 9.0 ubi and basic will be the same so this would mean minus one variant that has to be removed from main.

@ycombinator what do you think?

@ycombinator
Copy link
Contributor

Looks like the overall time is still lower then the integration tests execution time so we should be good on that end. Starting 9.0 ubi and basic will be the same so this would mean minus one variant that has to be removed from main.

@ycombinator what do you think?

I tend to agree but I'm also wondering: how much more effort would it be to run TestKubernetesAgentStandaloneKustomize for each of the docker variants concurrently?

@rdner
Copy link
Member Author

rdner commented Oct 16, 2024

@jlind23 @ycombinator looks like we all agree that the overall runtime of the tests won't change after merging this (because the agent integration tests are running for even longer).

I think changing the test framework to run these images concurrently is out of the scope of this task, here is the issue to follow up #5801

@rdner rdner merged commit 9e5b8a7 into elastic:main Oct 16, 2024
18 checks passed
@rdner rdner deleted the k8s-wolfi-tests branch October 16, 2024 14:52
mergify bot pushed a commit that referenced this pull request Oct 16, 2024
So, we validate all produced images.

(cherry picked from commit 9e5b8a7)
pierrehilbert pushed a commit that referenced this pull request Oct 16, 2024
So, we validate all produced images.

(cherry picked from commit 9e5b8a7)

Co-authored-by: Denis <denis.rechkunov@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate testing of the Wolfi container in Kubernetes
4 participants