Exclude the coverage files from the annotate step #5773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
This is something that was introduced with elastic#377 and was meant to be used with Jenkins to show coverage report. Now with Jenkins been replace and BK + Sonar enabled on the repo, there is no need to create such artifacts anymore. Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
rowlandgeoff
approved these changes
Oct 14, 2024
|
The problem was that the annotation plugin was reading the coverage files, which are converted to XML format with the help of the That was needed back when we combined Jenkins with some Jenkins plugins. We could keep creating that XML file, but we don't use it anymore, thus I removed it. |
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
|
jlind23
approved these changes
Oct 15, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* Exclude the coverage files from the annotate step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit 8ebaa7d)
pazone
pushed a commit
that referenced
this pull request
Dec 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Exclude the coverage files from the annotate step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit 8ebaa7d)
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
* Exclude the coverage files from the annotate step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit 8ebaa7d)
This was referenced Dec 13, 2024
jlind23
pushed a commit
that referenced
this pull request
Dec 30, 2024
jlind23
added a commit
that referenced
this pull request
Dec 30, 2024
* Exclude the coverage files from the annotate step Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> (cherry picked from commit 8ebaa7d) Co-authored-by: Alexandros Sapranidis <alexandros@elastic.co> Co-authored-by: Julien Lind <julien.lind@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We noticed that the JUnit annotate step needed to take more time. This PR addresses that issue by not requiring it to parse the coverage files.
The generated coverage XML file was meant to be used in Jenkins to show the coverage report stats. The generated XML files were large, resulting in a problem with BK's JUnit annotate plugin.
Given that we don't operate any Jenkins instance, this PR removes the code that generated the XML coverage reports.
Now, coverage is reported only to Sonar.
Why is it important?
Reduce the time of CI step