Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrying choco install #5764

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Retrying choco install #5764

merged 1 commit into from
Oct 13, 2024
+5 −3

Conversation

rowlandgeoff
Copy link
Contributor

@rowlandgeoff rowlandgeoff commented Oct 11, 2024 •
edited
Loading

Retrying the choco install step to reduce the flakiness of integration test runs.

Rel: https://github.com/elastic/ingest-dev/issues/4245

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024

This pull request does not have a backport label. Could you fix it @rowlandgeoff? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 11, 2024
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@rowlandgeoff rowlandgeoff added the backport-8.15 Automated backport to the 8.15 branch with mergify label Oct 11, 2024
@rowlandgeoff rowlandgeoff marked this pull request as ready for review October 11, 2024 19:27
@rowlandgeoff rowlandgeoff requested a review from a team as a code owner October 11, 2024 19:27
@rowlandgeoff rowlandgeoff requested review from blakerouse, swiatekm, pazone and a team October 11, 2024 19:27
@pierrehilbert pierrehilbert merged commit d6da7eb into main Oct 13, 2024
17 checks passed
@pierrehilbert pierrehilbert deleted the chocoRetry branch October 13, 2024 12:42
mergify bot pushed a commit that referenced this pull request Oct 13, 2024
@rowlandgeoff @mergify
Attempt at retrying choco install (#5764)
ecba5da 
(cherry picked from commit d6da7eb)

# Conflicts:
#	pkg/testing/runner/windows.go
mergify bot pushed a commit that referenced this pull request Oct 13, 2024
@rowlandgeoff @mergify
Attempt at retrying choco install (#5764)
baaeab0 
(cherry picked from commit d6da7eb)
This was referenced Oct 13, 2024
Merged
Merged
pierrehilbert pushed a commit that referenced this pull request Oct 14, 2024
@mergify @rowlandgeoff
Attempt at retrying choco install (#5764) (#5771)
0bb720c 
(cherry picked from commit d6da7eb)

Co-authored-by: Geoff Rowland <70981735+rowlandgeoff@users.noreply.github.com>
rowlandgeoff added a commit that referenced this pull request Oct 18, 2024
@mergify @rowlandgeoff
[8.15](backport #5764) Retrying choco install (#5770)
cd7202b 
* Attempt at retrying choco install (#5764)

(cherry picked from commit d6da7eb)

# Conflicts:
#	pkg/testing/runner/windows.go

* Update windows.go

---------

Co-authored-by: Geoff Rowland <70981735+rowlandgeoff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse is a code owner automatically assigned from elastic/elastic-agent-control-plane

@swiatekm swiatekm Awaiting requested review from swiatekm swiatekm is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pazone pazone Awaiting requested review from pazone

Assignees

@rowlandgeoff rowlandgeoff

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rowlandgeoff @cmacknz @pierrehilbert