Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS for Eng Prod ownership #5761

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Update CODEOWNERS for Eng Prod ownership #5761

merged 1 commit into from
Oct 11, 2024

Conversation

rowlandgeoff
Copy link
Contributor

Update CODEOWNERS so the Eng Prod team is automatically added to reviews where CI is getting updated.

@rowlandgeoff rowlandgeoff requested a review from a team as a code owner October 11, 2024 15:22
@rowlandgeoff rowlandgeoff requested review from blakerouse, swiatekm and a team October 11, 2024 15:22
@rowlandgeoff rowlandgeoff self-assigned this Oct 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024

This pull request does not have a backport label. Could you fix it @rowlandgeoff? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 11, 2024
@rowlandgeoff
Copy link
Contributor Author

Note to self: the skip-ci label doesn't seem to work:
image

@rowlandgeoff
Copy link
Contributor Author

/test

@rowlandgeoff
Copy link
Contributor Author

buildkite test this

@rowlandgeoff
Copy link
Contributor Author

CI isn't triggering now, it may be an effect of having tried the skip-ci label. Considering this change safe and merging.

@rowlandgeoff rowlandgeoff merged commit 55bed2f into main Oct 11, 2024
7 of 10 checks passed
@rowlandgeoff rowlandgeoff deleted the codeownersUpdate branch October 11, 2024 15:46
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@rowlandgeoff @mergify
Update CODEOWNERS for Eng Prod ownership (#5761)
a01ebd1 
(cherry picked from commit 55bed2f)
@mergify mergify bot mentioned this pull request Oct 11, 2024
Merged
@rowlandgeoff rowlandgeoff added the backport-8.15 Automated backport to the 8.15 branch with mergify label Oct 11, 2024
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@rowlandgeoff @mergify
Update CODEOWNERS for Eng Prod ownership (#5761)
9dc22c9 
(cherry picked from commit 55bed2f)
@mergify mergify bot mentioned this pull request Oct 11, 2024
Merged
rowlandgeoff added a commit that referenced this pull request Oct 11, 2024
@mergify @rowlandgeoff
Update CODEOWNERS for Eng Prod ownership (#5761) (#5762)
6f7a8c3 
(cherry picked from commit 55bed2f)

Co-authored-by: Geoff Rowland <70981735+rowlandgeoff@users.noreply.github.com>
pierrehilbert pushed a commit that referenced this pull request Oct 13, 2024
@mergify @rowlandgeoff
Update CODEOWNERS for Eng Prod ownership (#5761) (#5765)
6dd7a9e 
(cherry picked from commit 55bed2f)

Co-authored-by: Geoff Rowland <70981735+rowlandgeoff@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@jlind23 jlind23 jlind23 approved these changes

@swiatekm swiatekm swiatekm approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse was automatically assigned from elastic/elastic-agent-control-plane

Assignees

@rowlandgeoff rowlandgeoff

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rowlandgeoff @pierrehilbert @jlind23 @swiatekm