Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BK Integration tests: fix retry usage #5760

Merged
merged 9 commits into from
Oct 15, 2024
Merged

BK Integration tests: fix retry usage #5760

merged 9 commits into from
Oct 15, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Oct 11, 2024

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added the bug Something isn't working label Oct 11, 2024
@pazone pazone requested a review from a team as a code owner October 11, 2024 14:58
@pazone pazone requested review from blakerouse and swiatekm October 11, 2024 14:58
@mergify mergify bot assigned pazone Oct 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 11, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 11, 2024
@rowlandgeoff
Copy link
Contributor

I'll sign off when I see the results of CI and the test run pass: https://buildkite.com/elastic/elastic-agent-extended-testing-bk

@rowlandgeoff
Copy link
Contributor

@pazone More fixes are needed. The test run has been hanging for 2.5 hours with this repeated message. I'm canceling the run.

No preset version installed for command terraform
Please install a version by running one of the following:

asdf install terraform 1.9.3

or add one of the following versions in your config file at
terraform 1.9.2

@pazone pazone requested a review from a team as a code owner October 14, 2024 09:38
@pazone
Copy link
Contributor Author

pazone commented Oct 14, 2024

Added a few more commits. Now it works. Here is the example build

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pazone pazone merged commit 431b094 into main Oct 15, 2024
14 checks passed
@pazone pazone deleted the integration_bk_tests_fotfix branch October 15, 2024 07:49
mergify bot pushed a commit that referenced this pull request Oct 15, 2024
@pazone @mergify
BK Integration tests: fix retry usage (#5760)
1c8eea1 
* Integration tests: fix retry usage

* Integration tests: fix retry usage

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Pin agent version

* Pin agent version

(cherry picked from commit 431b094)
@mergify mergify bot mentioned this pull request Oct 15, 2024
Merged
7 tasks
oakrizan pushed a commit that referenced this pull request Nov 21, 2024
@mergify @pazone @pierrehilbert
BK Integration tests: fix retry usage (#5760) (#5786)
4eb4310 
Integration tests: fix retry usage

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
@oakrizan oakrizan added the backport-8.16 Automated backport with mergify label Dec 11, 2024
mergify bot pushed a commit that referenced this pull request Dec 11, 2024
@pazone @mergify
BK Integration tests: fix retry usage (#5760)
970e0c6 
* Integration tests: fix retry usage

* Integration tests: fix retry usage

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Pin agent version

* Pin agent version

(cherry picked from commit 431b094)
@mergify mergify bot mentioned this pull request Dec 11, 2024
Merged
7 tasks
ycombinator pushed a commit that referenced this pull request Dec 12, 2024
@mergify @pazone
BK Integration tests: fix retry usage (#5760) (#6278)
7272ca6 
* Integration tests: fix retry usage

* Integration tests: fix retry usage

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Correct terraform version

* Pin agent version

* Pin agent version

(cherry picked from commit 431b094)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowlandgeoff rowlandgeoff rowlandgeoff approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse blakerouse was automatically assigned from elastic/elastic-agent-control-plane

@swiatekm swiatekm Awaiting requested review from swiatekm swiatekm was automatically assigned from elastic/elastic-agent-control-plane

Assignees

@pazone pazone

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify bug Something isn't working skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pazone @rowlandgeoff @pierrehilbert @oakrizan @swiatekm