[8.x](backport #4722) Update labels to use kubernetes recommended labels #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes have not used the `app` or `k8s-app` for some time and have provided guidance on what the recommended labels are for some time as seen in their [docs](https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/). This commit updates all manifests/docs to use this approach. Co-authored-by: Julien Lind <julien.lind@elastic.co> (cherry picked from commit f2af90f)
pierrehilbert
approved these changes
Oct 11, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Kubernetes have not used the
appork8s-appfor some timeand have provided guidance on what the recommended labels are
for some time as seen in their docs.
This commit updates all manifests/docs to use this approach.
Why is it important?
Users who choose to adopt kubernetes label best practises will not have to fork elastic manifests and can instead rely on the upstream ones directly.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
Users will need to upgrade using
kubectl replaceas some of the labels are immutableThis is an automatic backport of pull request #4722 done by [Mergify](https://mergify.com).