-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add components for supporting APM functions #5713
Conversation
This pull request does not have a backport label. Could you fix it @lahsivjar? 🙏
|
|
This is blocked by dependency upgrade PRs, there are some dependency issues with EA - some dependencies are on v0.109.0 whereas others at v0.110.0. Even the latest update PR doesn’t upgrade all of them. |
This pull request is now in conflicts. Could you fix it? 🙏
|
f676ad6
to
463b596
Compare
463b596
to
d87f2fb
Compare
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this will unblock 8.16 Auto-instrumentation testing.
I am at a loss here on what is failing in the pipeline and the logs are not very helpful. Can someone point me in the correct direction or give me a clue? |
Looks like this is the culprit... not sure if it is related to my changes. I have triggered a retry 🤞 |
@lahsivjar Seems the CI succeed after the retry, is there any other blocker? |
@rogercoll No blockers but require reviews from the codeowners (merging is currently blocked). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's just a small inconsistency for one indirect otel-collector dependency, looks good otherwise
Good catch! It looks like collector-components has some pending PRs for component updates. Let me merge those and bump the version. |
We already have the replacement for spanmetricsconnectorv2 merged and ready to be released. Pausing this PR for a bit to add that component. UPDATE: Done! |
|
(cherry picked from commit f560826) # Conflicts: # NOTICE.txt # go.mod # go.sum # internal/pkg/otel/README.md
What does this PR do?
Adds the following component to support https://github.com/elastic/opentelemetry-dev/issues/372:
* [spanmetricsconnectorv2](https://github.com/elastic/opentelemetry-collector-components/tree/main/connector/spanmetricsconnectorv2) - this component will be removed in favor of a new component soon * [countconnector](https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/connector/countconnector)Why is it important?
Required for https://github.com/elastic/opentelemetry-dev/issues/372
Related issues
Closes https://github.com/elastic/opentelemetry-dev/issues/390