Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5610) Handle BUILDKITE_MESSAGE length in pre-command.ps1 #5632

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 30, 2024

Description of problem:
Windows unit test pre-command steps were failing in CI when the BUILDKITE_MESSAGE param was too long, which would occur when commits had very long descriptions. This sometimes happens from automated processes, such as dependency updates. The BUILDKITE_MESSAGE would be very long, which would fill the Windows env var buffer, preventing further pre-command steps from adding directories to the PATH.
Problem report: https://elastic.slack.com/archives/C0522G6FBNE/p1727193548224399

Fix:
Trim the BUILDKITE_MESSAGE param to the INTERNET_MAX_URL_LENGTH of 2048.
This was tested in draft PR #5609 with very long and short commit messages. I confirmed that the Windows unit test steps got past the pre-command phase.

References:

@mergify mergify bot requested a review from a team as a code owner September 30, 2024 19:02
@mergify mergify bot added the backport label Sep 30, 2024
@mergify mergify bot requested review from blakerouse and pkoutsovasilis and removed request for a team September 30, 2024 19:02
@rowlandgeoff rowlandgeoff enabled auto-merge (squash) September 30, 2024 20:37
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@rowlandgeoff rowlandgeoff merged commit 437d545 into 8.x Oct 1, 2024
14 checks passed
@rowlandgeoff rowlandgeoff deleted the mergify/bp/8.x/pr-5610 branch October 1, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant