Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloud-defend from agent #5481

Merged
merged 16 commits into from
Oct 8, 2024
Merged

Conversation

mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Sep 9, 2024

What does this PR do?

cloud-defend (a.k.a. Defend for Containers) will be removed from the next major release. This removes cloud-defend from agent, by removing it from packaging scripts and template kubernetes files.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

Defend for Containers never left beta, so although removing it could be disruptive to users of the integration, it's acceptable to be a breaking change in a major update.

How to test this PR locally

After building the agent package, inspect it to ensure the cloud-defend package is not included in it, and the cloud-defend executable isn't on the system after installing the agent.

cloud-defend will be removed from the next major release. This removes cloud-defend
from agent, by removing it from packaging scripts and from template kubernetes files.
@cmacknz
Copy link
Member

cmacknz commented Sep 9, 2024

Thanks! I'll hold on approving this until main has cut over to 9.0 so this doesn't accidentally ship in 8.16.

@ycombinator ycombinator requested review from cmacknz and removed request for swiatekm September 10, 2024 00:16
Copy link
Contributor

mergify bot commented Sep 10, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@swiatekm swiatekm removed backport-v8.x backport-8.x Automated backport to the 8.x branch with mergify labels Sep 11, 2024
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@mjwolf mjwolf removed the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@mjwolf mjwolf removed the backport-8.x Automated backport to the 8.x branch with mergify label Sep 13, 2024
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@pierrehilbert pierrehilbert added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Sep 16, 2024
cloud-defend will be removed from the next major release. This removes cloud-defend
from agent, by removing it from packaging scripts and from template kubernetes files.
@jlind23
Copy link
Contributor

jlind23 commented Oct 7, 2024

@cmacknz now that main became 9.0 can we make it land?

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jlind23 jlind23 merged commit ce5f623 into elastic:main Oct 8, 2024
14 checks passed
@mjwolf mjwolf deleted the remove-cloud-defend branch October 24, 2024 16:25
@mbudge
Copy link
Contributor

mbudge commented Jan 24, 2025

We we're planning on using Cloud Defend for Containers this year. Is this been moved to another agent or is it totally depreciated?

@nick-alayil
Copy link

@mbudge

is it totally depreciated?

Yes, Defend for Containers (D4C) has been deprecated from serverless and Elastic Stack / ECH 9.0.0. D4C will remain available in the 8.x stack as beta. While D4C is being sunset, we're actively in the process of building a new SIEM aligned k8s security solution. IIRC, you're planning to use Azure Red Hat OpenShift, I'd welcome the opportunity to schedule a call to discuss the following:

  • Strategic reasoning behind this decision
  • Technical considerations that led to D4C deprecation
  • Our future direction for k8s security
  • Your specific k8s security reqs and use cases
  • How our new solution can address your needs
  • Potential interim solutions using our current capabilities

I'll reach out to you to find a time that works best for this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants