Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the integration tests framework documentation #5461

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Sep 6, 2024

What does this PR do?

It improves the integration tests framework documentation on how to debug test from the remove VMs.

Why is it important?

It improves the integration tests framework documentation on how to debug test from the remove VMs.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

## Disruptive User Impact
## How to test this PR locally
## Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@belimawr belimawr added Team:Elastic-Agent Label for the Agent team skip-changelog labels Sep 6, 2024
@belimawr belimawr requested a review from a team as a code owner September 6, 2024 16:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Copy link
Contributor

mergify bot commented Sep 6, 2024

This pull request does not have a backport label. Could you fix it @belimawr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

mergify bot commented Sep 10, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b improve-integ-test-docs upstream/improve-integ-test-docs
git merge upstream/main
git push upstream improve-integ-test-docs

@belimawr belimawr force-pushed the improve-integ-test-docs branch from a4a2f16 to 0dbc325 Compare September 10, 2024 13:33
Copy link
Contributor

mergify bot commented Sep 10, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@ycombinator ycombinator added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Sep 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell, but I'd prefer someone more familiar with the framework to review too.

@v1v v1v removed the backport-v8.x label Sep 11, 2024
@belimawr belimawr enabled auto-merge (squash) September 12, 2024 21:03
@belimawr
Copy link
Contributor Author

It seems this PR is waiting on SonarQube even though it only changes documentation. 🤔

I enabled auto-merge and I'll look more into it tomorrow.

@ycombinator
Copy link
Contributor

No need for SonarQube check on this docs-only PR. Force merging...

@ycombinator ycombinator merged commit d99b09b into elastic:main Sep 12, 2024
11 checks passed
mergify bot pushed a commit that referenced this pull request Sep 12, 2024
* Improve the integration tests framework documentation

* Fix typo

(cherry picked from commit d99b09b)
pierrehilbert pushed a commit that referenced this pull request Sep 16, 2024
* Improve the integration tests framework documentation

* Fix typo

(cherry picked from commit d99b09b)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-skip skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants