Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #5333) Avoid reporting empty version_info for components that just started #5404

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 3, 2024

What does this PR do?

The state diagnostics hook now re-fetches once the state when necessary, improving the accuracy of component status reporting.

Why is it important?

Given a design choice, the coordinator's reported state might be stale, leading to healthy components lacking version_info immediately after they start.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Run the TestDiagnosticState test

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #5333 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner September 3, 2024 11:51
@mergify mergify bot added the backport label Sep 3, 2024
@mergify mergify bot requested review from blakerouse and michel-laterman and removed request for a team September 3, 2024 11:51
Copy link

@AndersonQ AndersonQ marked this pull request as draft September 4, 2024 14:14
@AndersonQ
Copy link
Member

closing in favour of #5436

@AndersonQ AndersonQ closed this Sep 5, 2024
@mergify mergify bot deleted the mergify/bp/8.x/pr-5333 branch September 5, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant