-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace math/rand with math/rand/v2 #5336
Conversation
This pull request does not have a backport label. Could you fix it @mauri870? 🙏
NOTE: |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very mechanical, looks good.
fde80c6
to
4400321
Compare
4400321
to
eab5e57
Compare
changelog/fragments/1724253791-replace-math-rand-with-math-rand-v2.yaml
Outdated
Show resolved
Hide resolved
Test failure seems to be unrelated and is being tracked at #5279. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR updates all occurrences of math/rand with the new math/rand/v2 introduced in Go 1.22.
Why is it important?
The math/rand/v2 includes performance and scalability improvements.
Checklist
./changelog/fragments
using the changelog toolHow to test this PR locally
Related issues