-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker image running Elastic Agent in Otel mode #5248
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
32ac337
working otel image
michalpristas 96ec96a
Merge branch 'main' into otel/docker
michalpristas d13dac9
Merge branch 'main' of github.com:elastic/elastic-agent into otel/docker
michalpristas 31a6349
keep otel as close to agent as possible
michalpristas 73bc1bb
Merge branch 'otel/docker' of github.com:michalpristas/elastic-agent …
michalpristas dee9944
Merge branch 'main' into otel/docker
michalpristas 87f2b14
otel mode based on ENV
michalpristas 79df9cc
playing with tests
michalpristas dc48985
otel tests separately
michalpristas 637c98b
revert configmap
michalpristas fe7501f
Merge branch 'main' into otel/docker
michalpristas ff92fa0
Merge branch 'main' into otel/docker
michalpristas 8b1b37e
Merge branch 'main' into otel/docker
blakerouse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there actually a way you can tell we started the OTel collector?
This test would still pass if we started elastic agent as usual, but disabled monitoring and didn't use the system/metrics integration/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but scenario you mentioned is not the default config nor any config we test with so chance of false positive is really small, especially when agent is reported healthy.
no way to tell agent is in otel besides logs that are with default config printed to stdout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't an HTTP port or something that returns otel specific data or something?
I don't feel that strongly about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improving this is something we could follow up with.