use go-sysinfo v1.14.1 and elastic-agent-system-metrics v0.10.6 #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
NOTE: |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
go-sysinfo was lower-casing FQDN by default, this new version does not. Not its user should do it if necessary. elastic-agent-system-metrics is also upgraded to a version that lowercase the FQDN when it's used as `host.name`.
044f5ca to
486d164
Compare
|
|
@AndersonQ linting is failing. LGTM otherwise |
VihasMakwana
approved these changes
Jul 26, 2024
michalpristas
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
go-sysinfo was lower-casing FQDN by default, this new version does not.
elastic-agent-system-metricsis also upgraded to a version that lowercase the FQDN when it's used ashost.name.Also it includes the necessary changes to handle the cases where FQND is used for
host.nameand should be lowercased to follow ECS conventions.Why is it important?
The FQDN should not always be lowercased, only when used as
host.nameChecklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
By fixing elastic/beats#39993 it might cause the opposite effect and some users which were seeing
host.hostnamelower-cased now might see it with mixed case.How to test this PR locally
Follow the procedure explained on elastic/beats#39993
with this fix:
Related issues
host.hostnameis being lowercased beats#39993Questions to ask yourself