-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for $$
appearing within policy inputs
#5097
Conversation
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
NOTE: |
$$
appearing within policy inputs
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Skipping the changelog check as this PR is only adding Unit Tests |
What does this PR do?
Add unit tests for special characters, mainly the escape sequence of
$$
in the transpiler, and input parsing of policies.Why is it important?
Secrets are being incorrectly formatted when they contain these characters.
This also applies to any
key: value
pair the user specifies in the fleet-ui.Testing found that this is caused by the UI escaping
$$
to$
; but we should have unit tests in the agent to ensure we don't inadvertently introduce a regression.Related issues
$$
or${SOMETEXT}
kibana#188377