Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the enroll sub command help #5048

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

AndersonQ
Copy link
Member

What does this PR do?

Improves the enroll sub command help

Why is it important?

Currently leads to misunderstanding and miss use of the flag by our users.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

None

How to test this PR locally

run elastic-agent help enroll and check the help was updated

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@AndersonQ AndersonQ added documentation Improvements or additions to documentation Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-v8.14.0 Automated backport with mergify labels Jul 3, 2024
@AndersonQ AndersonQ self-assigned this Jul 3, 2024
@AndersonQ AndersonQ requested a review from a team as a code owner July 3, 2024 13:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AndersonQ AndersonQ enabled auto-merge (squash) July 3, 2024 14:22
@AndersonQ AndersonQ merged commit a1fc480 into elastic:main Jul 3, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Jul 3, 2024
AndersonQ added a commit that referenced this pull request Jul 3, 2024
(cherry picked from commit a1fc480)

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify documentation Improvements or additions to documentation skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify cli flags for TLS config for fleet-server, ES and the gent itself
3 participants