Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky test] Skip TestEndpointLogsAreCollectedInDiagnostics #4450

Closed
wants to merge 1 commit into from

Conversation

AndersonQ
Copy link
Member

What does this PR do?

Skip TestEndpointLogsAreCollectedInDiagnostics

Why is it important?

By skipping flaky tests, we're ushering in a new era of productivity, where teams can focus on delivering high-quality features without the hindrance of unreliable testing outcomes. Streamlining the development process, we optimize resource utilization, ensuring that valuable time and computing power are directed towards areas that truly matter. Our commitment to fostering a culture of trust means stakeholders can rely on accurate testing results to make informed decisions, accelerating time-to-market and giving your product a competitive edge. With increased confidence in testing outcomes, improved developer morale, and aligned testing strategies, we're not just skipping tests – we're embracing continuous improvement and shaping the future of software testing.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

How to test this PR locally

  • run the integration tests
  • TestEndpointLogsAreCollectedInDiagnostics will be skipped

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@AndersonQ AndersonQ added Team:Elastic-Agent Label for the Agent team flaky-test Unstable or unreliable test cases. backport-skip skip-changelog labels Mar 21, 2024
@AndersonQ AndersonQ self-assigned this Mar 21, 2024
@AndersonQ AndersonQ requested a review from a team as a code owner March 21, 2024 07:56
@AndersonQ AndersonQ requested review from blakerouse and pchila March 21, 2024 07:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@rdner
Copy link
Member

rdner commented Mar 21, 2024

Closing due to the existing fix #4453

@rdner rdner closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants