Fix flaky TestCoordinatorReportsInvalidPolicy #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
d8d754d to
f82f292
Compare
cmacknz
reviewed
Mar 14, 2024
|
@cmacknz I fixed the case statement, could you re-review it? |
|
0.0% Duplication on New Code
cmacknz
approved these changes
Mar 21, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
* increase state change timeout, fail fast and better error messages * print coordinator logs on failure (cherry picked from commit fc67134)
1 task
pierrehilbert
pushed a commit
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes flakyness of
TestCoordinatorReportsInvalidPolicyby increasing the state change timeout, failing fast and having better error messages and printing the coordinator logs if the test fails.Why is it important?
The test is flaky
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Related issues
Questions to ask yourself