Avoid drainErrChan hanging forever if the channel is closed #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
pchila
approved these changes
Feb 22, 2024
|
0.0% Duplication on New Code
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 00550ca)
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
(cherry picked from commit 00550ca)
This was referenced Feb 22, 2024
AndersonQ
added a commit
that referenced
this pull request
Feb 22, 2024
AndersonQ
added a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
drainErrChanto return if the channel is closed.As it's possible to read from a closed channel, if the channel passed to
drainErrChanis closed it'd never exit.Why is it important?
drainErrChanwould never return if received a closed channel and therefore would hang the test until it times out.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
check the behaviour here: https://go.dev/play/p/WVM-P8RwJaM
Related issues
Questions to ask yourself