Increase waiting time and timeout for removal of agent files #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
This pull request does not have a backport label. Could you fix it @pchila? 🙏
NOTE: |
|
100.0% Coverage on New Code
0.0% Duplication on New Code
rdner
approved these changes
Feb 22, 2024
|
I think we should backport this to 8.12 and 8.13. Added the labels. |
michalpristas
approved these changes
Feb 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
* increase waiting time and timeout for removal of agent files (cherry picked from commit 2eecafb)
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
* increase waiting time and timeout for removal of agent files (cherry picked from commit 2eecafb)
pchila
added a commit
that referenced
this pull request
Feb 22, 2024
* increase waiting time and timeout for removal of agent files (cherry picked from commit 2eecafb)
pchila
added a commit
that referenced
this pull request
Feb 22, 2024
pchila
added a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR increases the timeout for removing files during
elastic-agent uninstalland slows down retries to give time to the OS (especially windows) to release locks on the agent files.This comes after checking the results of #4304 where we verified that no lingering agent processes were present when we still had some
access deniederrors on executable filesWhy is it important?
This should prevent failures in our integration tests where we install/uninstall agent in quick succession.
It's also something that should make the uninstall process more reliable on a slower (especially windows) machine by giving more time to the OS to release files.
On a machine that already managed to deal with the quicker timeout (linux/darwin) there could be a negligible slowdown (most likely none) due to the slower interval between attempts.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself