Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12](backport #4039) Disable Go Workspaces when executing 'go list' in agent packaging process #4113

Merged
merged 4 commits into from
Jan 31, 2024
Merged

[8.12](backport #4039) Disable Go Workspaces when executing 'go list' in agent packaging process #4113

merged 4 commits into from
Jan 31, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 22, 2024

This is an automatic backport of pull request #4039 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@AndersonQ @mergify
Disable Go Workspaces when executing 'go list' in agent packaging pro…
be2e06c 
…cess (#4039)

running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.

(cherry picked from commit bccb12e)
@mergify mergify bot requested a review from a team as a code owner January 22, 2024 11:23
@mergify mergify bot added the backport label Jan 22, 2024
@mergify mergify bot requested review from michalpristas and pchila and removed request for a team January 22, 2024 11:23
@pierrehilbert pierrehilbert requested review from AndersonQ and removed request for michalpristas and pchila January 22, 2024 11:42
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Jan 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Jan 29, 2024

This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏

@AndersonQ AndersonQ enabled auto-merge (squash) January 31, 2024 15:23
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@AndersonQ AndersonQ merged commit 9db5527 into 8.12 Jan 31, 2024
6 of 9 checks passed
@AndersonQ AndersonQ deleted the mergify/bp/8.12/pr-4039 branch January 31, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonQ AndersonQ Awaiting requested review from AndersonQ

Assignees

@AndersonQ AndersonQ

Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @AndersonQ @pierrehilbert