Add agent hash to check for detecting upgrade rollbacks #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
ycombinator
reviewed
Nov 30, 2023
Comment on lines
87
to
88
| watcherAgentVersion string | ||
| watcherAgentHash string |
There was a problem hiding this comment.
These are not actually the watcher agent version and hash (as we discussed off-PR yesterday). Could you change these to agentVersion/agentHash or currentAgentVersion/currentAgentHash or something along those lines please?
ycombinator
approved these changes
Nov 30, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change rollback detection based on version check to include commit hash.
For improving related integration tests changes from #3827 and #3837 are needed
Why is it important?
This allows correct version detection in case of upgrade between different builds of the same SNAPSHOT version
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Related issues
UPG_WATCHINGfor the entire time that the upgrade is being watched #3827Use cases
Screenshots
Logs
Questions to ask yourself