-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove race detector platform restrictions and enable it in CI #2743
Conversation
The race detector is now supported on arm64 and aarch64.
This pull request does not have a backport label. Could you fix it @cmacknz? 🙏
NOTE: |
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures> Show only the first 10 test failures
|
Ouch, these are all race detector failures: https://fleet-ci.elastic.co/job/elastic-agent/job/elastic-agent-mbp/job/PR-2743/2/testReport/ ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Switching the assignee here to @faec to triage the failures here and get them fixed before we merge this as part of the next watcher rotation. |
I think we will want to attempt the same thing for Beats, at least the amd64 platform restriction also exists there since the agent code was copied from there: https://github.com/elastic/beats/blob/dd1ea21dcd259d8669ca095f6ea852ddf23a134c/dev-tools/mage/gotest.go#L240-L245 |
Closing in favor of #2790 since I'm taking on the followup work for the failing tests |
We discovered in a recent PR that the RACE_DETECTOR environment variable seemingly was not having any effect (#2729 (comment)), it turns out it is ignored on arm64. This is now an unnecessary restriction.
I've also enabled the race detector in CI, I'll need to see what this does to the test time on each platform first though. We will keep it at least for Linux.