Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agents]: Error logs for linux and mac agent on adding/renaming integrations and restarting agent. #522

Closed
amolnater-qasource opened this issue Jun 7, 2022 · 12 comments
Labels
8.6-candidate bug Something isn't working impact:low Long-term priority, unless it's a quick fix. QA:Validated Validated by the QA Team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@amolnater-qasource
Copy link

amolnater-qasource commented Jun 7, 2022

Kibana version: 8.3 BC2 Kibana cloud environment

Host OS and Browser version: Ubuntu 20 and MAC , All

Build details:

VERSION: 8.3.0
BUILD: 53231
COMMIT: 25476b531ba9f32292bde85508d342aa5e1c29eb
Artifact Link: https://staging.elastic.co/8.3.0-fcd43da7/downloads/beats/elastic-agent/elastic-agent-8.3.0-darwin-x86_64.tar.gz

Preconditions:

  1. 8.3 BC2 Kibana cloud environment should be available.
  2. Linux and MAC agent must be installed using policy having System integration.

Steps to reproduce:

  1. Login to Kibana environment.
  2. Update name for system integration
  3. Observe error logs under Logs tab.

Impact:
No other impact on agent behaviour is observed.

Screenshot:

11

Expected Result:
Error logs should not be available on changing system integration name.

Logs:
elastic-agent-diagnostics-2022-06-07T11-47-45Z-00.zip

@amolnater-qasource amolnater-qasource added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team impact:low Long-term priority, unless it's a quick fix. labels Jun 7, 2022
@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@amolnater-qasource
Copy link
Author

Hi @jlind23
While testing on 8.3 BC5 Kibana cloud environment, we have observed this issue still reproducible.

  • On adding endpoint security to the policy we have observed these error logs for MAC and linux agents.

Build details:
BUILD: 53457
COMMIT: ba70bdf9fe5d28e832c40b7dbdade1e582133af1

Logs:
elastic-agent-diagnostics-2022-06-20T06-19-07Z-00.zip

Screenshot:
7

Thanks

@jlind23
Copy link
Contributor

jlind23 commented Jun 20, 2022

@kvch @fearful-symmetry could you help us out here as the panic seems to occur in the Elastic Agent lib.

@fearful-symmetry
Copy link
Contributor

So, the actual panic is happening here: https://github.com/elastic/beats/blob/667266f141e63c32b42f97e6f5d16be05638b0e6/metricbeat/beater/metricbeat.go#L276

The part in the agent lib is just the helper function that's calling that Close() on a sigint. As far as I can tell, aside from the code being migrated to elastic-agent-lib, I don't see any sign that this code has changed recently. I'm guessing this is a change somewhere else impacting how metricbeat is being shut down by agent itself. Is this present on 8.2?

@amolnater-qasource
Copy link
Author

Hi @fearful-symmetry
We have revalidated this issue on 8.2.3 released kibana cloud build and found it not reproducible there.

  • No error logs were observed on adding Endpoint Security or renaming system integration for Linux and MAC agent on 8.2.3.

Screenshot:
15
16

Build details:
BUILD: 52239
COMMIT: b6ed351db30239b669b6f4950d70d1d1bd9253c5

Please let us know if anything else is required from our end.
Thanks

@amolnater-qasource
Copy link
Author

Hi @jlind23
We have revalidated this issue on latest 8.4 BC6 Kibana cloud environment and found this issue still reproducible.

Observations:

  • Error logs are available under Logs tab for MAC and Linux agent on adding Endpoint Security or an agent restart.

Build details:
BUILD: 55395
COMMIT: 1922ab0b6f8dc2906ef10f3fb65fc4d0e0076f90

Logs:
MAC:
elastic-agent-diagnostics-MAC.zip
Linux:
elastic-agent-diagnostics-Linux1.zip
elastic-agent-diagnostics-Linux2.zip

Please let us know if anything else is required from our end.
Thanks

@amolnater-qasource amolnater-qasource changed the title [Agents]: Error logs for linux and mac agent on changing system integration name. [Agents]: Error logs for linux and mac agent on adding/renaming integrations and restarting agent. Aug 23, 2022
@jlind23
Copy link
Contributor

jlind23 commented Aug 23, 2022

@pierrehilbert could you please triage it?

@pierrehilbert
Copy link
Contributor

It seems to be related to:
elastic/beats#32608 (comment)

@jlind23
Copy link
Contributor

jlind23 commented Apr 4, 2023

@amolnater-qasource is this still a problem you are facing? As Pierre said this should have been fixed already: #522 (comment)

@jlind23
Copy link
Contributor

jlind23 commented Apr 4, 2023

Closing for now and I'll let you reopen if needed

@jlind23 jlind23 closed this as completed Apr 4, 2023
@amolnater-qasource amolnater-qasource added the QA:Ready For Testing Code is merged and ready for QA to validate label Apr 4, 2023
@amolnater-qasource
Copy link
Author

Hi Team,
We have revalidated this issue on latest 8.8.0 SNAPSHOT and found it fixed now.

Observations:

  • No above reported error logs are observed for linux agent on adding/renaming integrations and restarting agent.

Build details:
VERSION: 8.8.0-SNAPSHOT
BUILD: 61970
COMMIT: 5d5e5d3c913fe7a23fb53b79acaaff75c90d2c88

Screenshot:
7

Hence we are marking this issue as QA:Validated.

Thanks

@amolnater-qasource amolnater-qasource added QA:Validated Validated by the QA Team and removed QA:Ready For Testing Code is merged and ready for QA to validate labels Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6-candidate bug Something isn't working impact:low Long-term priority, unless it's a quick fix. QA:Validated Validated by the QA Team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

5 participants