This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Add a detailed README and clean up the configuration file #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmacknz
added
the
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
label
Aug 15, 2022
The test failures are all the same. The fix is one one of @rdner's branches:
|
- Include design goals and architecture details. - Include a section on client development. - Include contributing and development sections.
- Document all fields in the config file. - Move some general parameters under the server object.
faec
approved these changes
Aug 15, 2022
rdner
suggested changes
Aug 16, 2022
Co-authored-by: Denis Rechkunov <denis@rdner.de>
Co-authored-by: Denis Rechkunov <denis@rdner.de>
rdner
approved these changes
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a detailed README file that includes an architecture diagram. Also cleans up the configuration file a little bit and documents all of the fields in the style of the Beats and Agent reference configurations.
It will be easiest to review the rendered README: https://github.com/cmacknz/elastic-agent-shipper/blob/add-readme/README.md
Closes #61