This repository has been archived by the owner on Sep 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand mage and add build options #73
Expand mage and add build options #73
Changes from all commits
f58d6a9
bdea14a
51ba2db
80e84a7
e082b45
6968cde
d5f247e
5a9df25
b984b1d
d9034f7
b83be8a
b85bb5b
e480da7
7d56bcf
a6520ef
a5d752b
105d147
ae0b7b7
6df1da5
6dff21d
a13bfa2
940c526
e35a4fd
08583d3
ea5c82d
a4c2e0d
b26fb74
bdfc818
5fb2eec
bdadced
51c7c40
223c098
abff0ba
160f981
81b1e6e
981a418
fb3f91a
a26ab2f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not familiar with the
withMageEnv
call but I assume it generates thejunit-report.xml
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why viscose disappeared?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's still there, in
#directories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we have more flags than that? like
-s
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Does goreleaser support creating universal binary or we have to have a post build hook to merge both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might be lucky using this https://goreleaser.com/customization/universalbinaries/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be simple to share with different projects.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we shoot a warning here? maybe you want to know you provided incorrect value, may be a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you are using a Print* methods and a writer, it should not mark any usage.
The above allow you to enable the output or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is windows ok with
/
?