Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildkite: add test for macos #163

Merged
merged 8 commits into from
Nov 28, 2023
Merged

Buildkite: add test for macos #163

merged 8 commits into from
Nov 28, 2023

Conversation

leo-ri
Copy link
Contributor

@leo-ri leo-ri commented Nov 16, 2023

What does this PR do? Why is it important?

For completion migration from Jenkins to Buildkite need to add macos-test step

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

everything is green

Related issues

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@leo-ri leo-ri marked this pull request as ready for review November 28, 2023 17:06
@leo-ri leo-ri requested a review from a team as a code owner November 28, 2023 17:06
@leo-ri leo-ri requested review from ycombinator and leehinman and removed request for a team November 28, 2023 17:06
@jlind23 jlind23 merged commit 73fc009 into elastic:main Nov 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlind23 jlind23 jlind23 approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leo-ri @elasticmachine @jlind23