Beats: Add default_field: true to fieldsets #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 8.0, we are changing Beats to have an implicit `default_field: false` for all fields. This updates the generator to add `default_field: true` for fieldsets so that they continue to be added to the default field setting in the index template.
0026a30 to
3860ec8
Compare
|
/test |
kgeller
reviewed
Oct 21, 2021
Improves readability
In case in the future we want to have a whole fieldset excluded from default_fields.
kgeller
approved these changes
Oct 21, 2021
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 8.0, we are changing Beats to have an implicit
default_field: falsefor all fields.This updates the generator to add
default_field: trueto ECS fieldsets so that they continue to be added to the default field setting in the index template.Relates to elastic/beats#28215