-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Label fields for additional types - Stage 0 #1341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A
flattened
object will index all leaf values tokeyword
. Numeric flattened field support is not yet available in Elasticsearch (elastic/elasticsearch#61550)Kibana has limited autocompletion and KQL support for
flattened
fields (elastic/kibana#25820).
Is waiting for Kibana support an option? I would prefer to change labels
to flattened
if it's an option.
Numeric labels are very similar to a use case that APM and Metrics has (dotted metric names where field names are not known ahead of time), described in elastic/elasticsearch#63530. The last comment on that issue suggests that `flattened will also be the answer, but I believe the Elasticsearch team are still investigating other options.
I would kinda prefer not to encode the type in the field name. In APM we're planning to take advantage of elastic/elasticsearch#69948 to dynamically set the field type without affecting field names. APM will install a set of well-known dynamic templates (e.g. "latency_histogram"), and will then specify that when indexing metrics whose names and types are not known ahead of time. Maybe we could formalise this in ECS?
I considered if switching the type to After better realizing the current Kibana limitations with
Nice, thanks for linking! I hadn't seen that feature yet. I do like the idea of standardizing the |
I'm going to pause work on this proposal for now and close the PR. I still think these two items are worth additional discussion, but I'd rather have a focused discussion on each separately.
With some of these other initiatives, what's proposed here doesn't feel like the best direction right now. |
Summary
Stage 0 proposal for adding nested fields to the
labels
object:labels.*
fields will remain typekeyword
labels.long.*
fields will be typelong
labels.double.*
fields will be typedouble
labels.boolean.*
fields will be typeboolean
Stage 0 (Strawperson) Criteria:
Preview of markdown proposal