Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify + Allow custom MDC lookup #193

Merged
merged 3 commits into from
Aug 14, 2022

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Aug 3, 2022

Allow sub-classes of JUL EcsFormatter to provide their own MDC lookup (which then allows to set it in the APM agent).
Remove the JUL MDC implementation as it is not required after all.

@apmmachine
Copy link
Contributor

apmmachine commented Aug 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T14:25:12.283+0000

  • Duration: 7 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 244
Skipped 0
Total 244

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge changed the title Allow custom MDC lookup Simplify + Allow custom MDC lookup Aug 8, 2022
@SylvainJuge SylvainJuge marked this pull request as ready for review August 8, 2022 14:40
@eyalkoren eyalkoren merged commit 8a5bb2f into elastic:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants