Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4 #2236

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2022

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4.

  • Autogenerated from job lock-versions: pr.

@terrancedejesus
Copy link
Contributor

terrancedejesus commented Aug 9, 2022

Quite a few double bumps that I see. No triple bumps and no version declines. Checked previous (forked) versions and those seem fine as well. These seem to be related to the version locking process which starts from 7.16, bumps the version and then at 8.3 we add new fields which bump the version again accounting for double bumps.

#2125

@terrancedejesus terrancedejesus requested a review from w0rk3r August 10, 2022 12:39
Copy link
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrancedejesus terrancedejesus merged commit cb2ca45 into main Aug 10, 2022
@terrancedejesus terrancedejesus deleted the version-lock-2a3b5844 branch August 10, 2022 13:19
protectionsmachine pushed a commit that referenced this pull request Aug 10, 2022
Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit cb2ca45)
protectionsmachine pushed a commit that referenced this pull request Aug 10, 2022
Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit cb2ca45)
protectionsmachine pushed a commit that referenced this pull request Aug 10, 2022
Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit cb2ca45)
protectionsmachine pushed a commit that referenced this pull request Aug 10, 2022
Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit cb2ca45)
protectionsmachine pushed a commit that referenced this pull request Aug 10, 2022
Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit cb2ca45)
protectionsmachine pushed a commit that referenced this pull request Aug 10, 2022
Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit cb2ca45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants