Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asset Inventory][Azure] Add missing resources and ECS fields required for GA #2954

Merged
merged 34 commits into from
Feb 12, 2025
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
cf43de5
add Azure RoleDefinition
kubasobon Jan 28, 2025
ec14ef5
add Azure Entra Groups
kubasobon Jan 29, 2025
3658d89
add Azure Entra Users
kubasobon Jan 29, 2025
4524cee
update Azure Service Principal category
kubasobon Jan 29, 2025
39f0f5c
fix missing tenant info in Azure
kubasobon Jan 30, 2025
e3e1991
add ECS to Roles
kubasobon Jan 30, 2025
b5eb163
add ECS Group fields to Asset definition
kubasobon Jan 30, 2025
7220a7d
start filling Azure ECS
kubasobon Jan 30, 2025
8abf160
add missing Blob Containers and fetch Labels/Tags where possible
kubasobon Jan 31, 2025
d8eae3e
Merge branch 'main' into asset-inv-azure-ga
kubasobon Jan 31, 2025
779c8d7
fix existing unit tests for Azure Inventory
kubasobon Jan 31, 2025
c8a49c4
reclassify Blob Container Service
kubasobon Jan 31, 2025
81e1efc
extract VM properties
kubasobon Jan 31, 2025
1e594a1
fix expected value
kubasobon Jan 31, 2025
9f1ac3c
align principal with cloud assets sheet
kubasobon Jan 31, 2025
2ec1c1a
make linters happier
kubasobon Jan 31, 2025
3a0bdcc
update all missing ECS fields
kubasobon Feb 3, 2025
3300847
fix test cases
kubasobon Feb 3, 2025
5dd1913
make test cases race-condition-proof
kubasobon Feb 3, 2025
2280f5d
remove redundant todo
kubasobon Feb 4, 2025
784db22
add helper func test
kubasobon Feb 4, 2025
237ebe1
extend test case
kubasobon Feb 4, 2025
7ae75e8
make linter happy
kubasobon Feb 4, 2025
7ce72d9
skip asset.go in coverage
kubasobon Feb 4, 2025
93b68f2
cover resource-graph file
kubasobon Feb 4, 2025
b8e4bbe
add test for BlobContainers
kubasobon Feb 12, 2025
a45c2bf
Merge branch 'main' into asset-inv-azure-ga
kubasobon Feb 12, 2025
5ddc594
update ASSETS.md
kubasobon Feb 12, 2025
e433fb4
use mapstructure.Decode
kubasobon Feb 12, 2025
c2ba320
unpack properties to struct and test it
kubasobon Feb 12, 2025
cb98e89
fixes for linters
kubasobon Feb 12, 2025
ab31f28
resolve conflict
kubasobon Feb 12, 2025
fa2677c
gci
kubasobon Feb 12, 2025
f39fd5b
Merge branch 'main' into asset-inv-azure-ga
kubasobon Feb 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
align principal with cloud assets sheet
  • Loading branch information
kubasobon committed Jan 31, 2025
commit 9f1ac3cb7777c3b46551e925ffeaa2ee455a1bf7
5 changes: 3 additions & 2 deletions internal/inventory/ASSETS.md
Original file line number Diff line number Diff line change
@@ -115,10 +115,11 @@ Container Registry: 100% (1/1)
Database: 100% (4/4)
File System Service: 100% (2/2)
Host: 100% (1/1)
Identity: 9% (1/11)
Identity: 0% (0/10)
Infrastructure: 8% (2/23)
Messaging Service: 100% (2/2)
Private Endpoint: 100% (1/1)
Service Account: 100% (1/1)
Service Usage Technology: 100% (2/2)
Snapshot: 100% (1/1)
Storage Bucket: 100% (1/1)
@@ -146,7 +147,6 @@ Web Service: 100% (1/1)
| Identity | Azure AD Group | | No ❌ |
| Identity | Azure AD Service Principal | | No ❌ |
| Identity | Azure AD User | | No ❌ |
| Identity | Azure Principal | Azure Principal | Yes ✅ |
| Identity | Azure Role | | No ❌ |
| Identity | Azure Role Assignment | | No ❌ |
| Identity | Azure Server AD Administrator | | No ❌ |
@@ -177,6 +177,7 @@ Web Service: 100% (1/1)
| Messaging Service | Azure Storage Queue | Azure Storage Queue | Yes ✅ |
| Messaging Service | Azure Storage Queue Service | Azure Storage Queue Service | Yes ✅ |
| Private Endpoint | Azure Storage Account | Azure Storage Account | Yes ✅ |
| Service Account | Azure Principal | Azure Principal | Yes ✅ |
| Service Usage Technology | Azure Storage Blob Service | Azure Storage Blob Service | Yes ✅ |
| Service Usage Technology | Azure Storage Table Service | | Yes ✅ |
| Snapshot | Azure Snapshot | Azure Snapshot | Yes ✅ |
Binary file modified internal/inventory/cloud_assets.xlsx
Binary file not shown.
Loading