Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Azure deletion to delete the whole resource group #1584

Merged
merged 7 commits into from
Nov 26, 2023
Merged

Revert Azure deletion to delete the whole resource group #1584

merged 7 commits into from
Nov 26, 2023

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Nov 23, 2023 •
edited
Loading

Summary of your changes

Instead of deleting the necessary resources we've decided to delete the whole resource group

Screenshot/Data

Screenshot 2023-11-26 at 12 59 38

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@jeniawhite jeniawhite requested a review from a team as a code owner November 23, 2023 08:37
@mergify Mergify
Copy link

mergify bot commented Nov 23, 2023

This pull request does not have a backport label. Could you fix it @jeniawhite? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited
Loading

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 39
⬜ Skipped 1

@jeniawhite jeniawhite requested a review from orestisfl November 23, 2023 09:20
@jeniawhite jeniawhite changed the title Fixing query for delete env disks Fixing query and deletion of Azure VM disks in delete env script Nov 23, 2023
@jeniawhite jeniawhite changed the title Fixing query and deletion of Azure VM disks in delete env script Revert Azure deletion to delete the whole resource group Nov 26, 2023
@jeniawhite jeniawhite enabled auto-merge (squash) November 26, 2023 15:00
@jeniawhite jeniawhite merged commit b16472d into elastic:main Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurevichdmitry gurevichdmitry gurevichdmitry approved these changes

@orestisfl orestisfl Awaiting requested review from orestisfl

Assignees

@jeniawhite jeniawhite

Labels
backport-skip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CIS Azure] Implement CI / E2E Integration workflow/job tests
3 participants
@jeniawhite @orestisfl @gurevichdmitry