Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resources limits conversion in ToInt64() used for logging #5596

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix resources limits conversion in ToInt64() used for logging #5596

merged 1 commit into from
Apr 25, 2022

Conversation

thbkrkr
Copy link
Contributor

@thbkrkr thbkrkr commented Apr 20, 2022

Fixed a small bug with no real impact because the method is only used for logging.

I also renamed the resource variable to res to avoid the collision with the imported package k8s.io/apimachinery/pkg/api/resource.

@thbkrkr thbkrkr added >bug Something isn't working v2.3.0 labels Apr 20, 2022
barkbay
barkbay approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@thbkrkr thbkrkr merged commit 6d14e35 into elastic:main Apr 25, 2022
@thbkrkr thbkrkr deleted the fix-toint64-autoscaling branch May 17, 2022 09:49
fantapsody pushed a commit to fantapsody/cloud-on-k8s that referenced this pull request Feb 7, 2023
@thbkrkr @fantapsody
Fix resources limits conversion in ToInt64() (elastic#5596)
a923501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barkbay barkbay barkbay approved these changes

Assignees
No one assigned
Labels
>bug Something isn't working v2.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thbkrkr @barkbay