Elasticsearch: Set status.ObservedGeneration from metadata.Generation. #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naemono
commented
Feb 7, 2022
pebrc
reviewed
Feb 14, 2022
|
run full pr build |
Set observedGeneration from metadata.generation when generating initial state during ES reconcile. Make observedGeneration optional in spec. Adjust docs for observedGeneration. Add .DS_Store to git ignore. Add tests for observedGeneration behavior. Add e2e test for observedGeneration.
Adjust wording for state during ES reconciliation, as it's not a pointer.
Update ObservedGeneration documentation/comments. Remove duplicative license header. Use named field in test struct.
Remove specific es generation test. Add generation test to all es mutation tests.
Update final generation e2e test step to be wrapped in test.Eventually
fd11076 to
395986e
Compare
…n status being set initially.
fantapsody
pushed a commit
to fantapsody/cloud-on-k8s
that referenced
this pull request
Feb 7, 2023
elastic#5331) * Add es.status.ObservedGeneration to ES spec. Set observedGeneration from metadata.generation when generating initial state during ES reconcile. Make observedGeneration optional in spec. Adjust docs for observedGeneration. Add .DS_Store to git ignore. Add tests for observedGeneration behavior. Add e2e test for observedGeneration. * Move observedGeneration to be more alphabetical in struct. Adjust wording for state during ES reconciliation, as it's not a pointer. * Correct Spelling * Update documentation in test * Update test comments * Update e2e test to just update annotations, not disable tls. * remove unused ctx * allow fake k8s client to be disable/enabled on demand * directive `//nolint:gosimple` is unused for linter gosimple (nolintlint) * Fix phantom lint error?? * no need for func in testing, just call DisableFailing * Remove MacOS files from gitignore. Update ObservedGeneration documentation/comments. Remove duplicative license header. Use named field in test struct. * rename test file * remove new build tag format from new e2e file. * Removing changes associated with a failing k8s client. * Update crd generation description. Remove specific es generation test. Add generation test to all es mutation tests. * Correct runtime spelling. Update final generation e2e test step to be wrapped in test.Eventually * Use errors.New when not needing formatting. * remove erroneous nolint * s/CompareClusterGenerations/CompareClusterGenerationsSteps/g * Fix indentation in state.go * Adjust ES generation tests because of recent change concerning unknown status being set initially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is Elasticsearch specific at the moment
related to #3392
This change allows status.ObservedGeneration to be kept in sync with metadata.Generation according to the rules described in the above issue. This change adds a set of unit tests which show more details into when observedGeneration will, and will not be updated according to any errors that may occur during ES reconciliation. All mutated end-to-end Elasticsearch tests include steps to show how this generation/observedGeneration change is intended to function in a true cluster.