-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Fix "read more" occurrence #5317
Conversation
Should we also replace the occurrences of "read the"? > grep ' [Rr]ead the' -r docs
docs/orchestrating-elastic-stack-applications/security/saml-authentication.asciidoc:TIP: Make sure you read the complete ...
docs/quickstart.asciidoc:IMPORTANT: Read the <<{p}-upgrading-eck,upgrade notes>> ...
docs/operating-eck/installing-eck.asciidoc: Read the <<{p}-ga-upgrade,upgrade documentation>> ... |
@thbkrkr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't replace the occurrences when the read
doesn't apply to the reader.
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix read more * Fix more read occurrences * Update docs/release-notes/1.7.0.asciidoc Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com> * Update docs/design/0005-configurable-operator.md Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com> Co-authored-by: Thibault Richard <thbkrkr@users.noreply.github.com>
This PR replaces "read more" with accessible content.
Rel: #5306
The generated content in
../reference/api-docs.asciidoc
is not in scope.