Fix Agent volumes when an association has no CA #4833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pebrc
approved these changes
Sep 14, 2021
david-kow
approved these changes
Sep 14, 2021
thbkrkr
added a commit
to thbkrkr/cloud-on-k8s
that referenced
this pull request
Sep 14, 2021
This commit fixes an issue that occurs if you associate an Agent with a Kibana without TLS. In this case, the association Agent<->Kibana does not have a CA and this breaks the volumeMounts of the Agent container because we returned instead of continuing to populate the slice of volumes.
thbkrkr
added a commit
that referenced
this pull request
Sep 14, 2021
This commit fixes an issue that occurs if you associate an Agent with a Kibana without TLS. In this case, the association Agent<->Kibana does not have a CA and this breaks the volumeMounts of the Agent container because we returned instead of continuing to populate the slice of volumes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
14aa58f is the fix. In a6be319 I took the opportunity to do a little refactoring (remove the warnings due to the unnecessary
volsslice allocation and the conflict between the package and the variable name forassociation).Resolves #4832 (comment).