Add support for Elliptic Curve Digital Signature Algorithm (ECDSA) signed certificates #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this please |
pebrc
approved these changes
Jul 5, 2021
There was a problem hiding this comment.
The change looks good. 👍 on an e2e test. I ran into the issue that the first curve I tried, secp256k1, was not supported. I believe Elasticsearch claims support for all curves mentioned in rfc5480 and rfc5915 (secp256k1 is not in those rfcs). But I could not find information on which curves are supported in Go.
|
jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the ECDSA signature algorithm.
This enhancement is compatible with the support of a custom CA for HTTP and transport layer.
I'll try to add an e2e test but I'm opening this PR to allow a first review of the design/implementation, which is mostly about replacing
*rsa.PrivateKeywith thecrypto.Signerinterface.Fix #4581