Skip to content

Commit

Permalink
Fix tests run dependency (#6970)
Browse files Browse the repository at this point in the history
I got confused at the last moment in 445aee2 with the dependencies of the step to run e2e tests. We need to depend on the step that creates the cluster, the dependencies on the build steps were already removed.

It was not catch in the PR because we use kind for PRs which is a provider that doesn't use a remoteConfig.
  • Loading branch information
thbkrkr authored Jul 3, 2023
1 parent d6610c8 commit 3a2ce8d
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .buildkite/e2e/pipeline-gen/pipeline.tpl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,12 @@ steps:
- label: ":k8s: :go: {{ $test.Name }}"
{{- end }}
key: "e2e-{{ $test.SlugName }}"
# let's be optimistic and run the tests without dependency on the images build

{{- if $test.RemoteKubeconfig }}
depends_on:
- "e2e-cluster-{{ $test.SlugName }}"
# let's be optimistic and run the tests without dependency on the images build
{{- end }}

env:
{{- range $key, $val := $test.Env }}
Expand Down

0 comments on commit 3a2ce8d

Please sign in to comment.