Do not fails hard if dashboard are not found #8977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its possible that a beat doesn't have any dashboards, instead of failling hard on that case we simply return the message to the user and we continue on any setup task. This commit wrap the minimum error related to dashboard and filesystem using errors.wrap after the beat setup command will inspect any error returned by the import dashboard, if they are of type ErrNotFound we will just display a message to the user and continue with the execution. Fixes: elastic#8949 and elastic#8933
ph
commented
Nov 7, 2018
| @@ -4,6 +4,7 @@ | |||
| import subprocess | |||
| from nose.plugins.attrib import attr | |||
| import unittest | |||
| from unittest import SkipTest | |||
There was a problem hiding this comment.
Hit this error when running the integration test with a 6.4 installation.
urso
reviewed
Nov 7, 2018
|
@urso updated, I have removed the line in the python code and fixed the err.Wrap. |
urso
approved these changes
Nov 7, 2018
ph
added a commit
to ph/beats
that referenced
this pull request
Nov 7, 2018
Its possible that a beat doesn't have any dashboards, instead of failling hard on that case we simply return the message to the user and we continue on any setup task. This commit wrap the minimum error related to dashboard and filesystem using errors.wrap after the beat setup command will inspect any error returned by the import dashboard, if they are of type ErrNotFound we will just display a message to the user and continue with the execution. Fixes: elastic#8949 and elastic#8933 **Notes:** We could do a bit more refactoring to allow the dashboard importer to better communication any hiccups, this was the minimal changes to make it work without adding too much risk. (cherry picked from commit 4e812da)
ph
added a commit
to ph/beats
that referenced
this pull request
Nov 7, 2018
Its possible that a beat doesn't have any dashboards, instead of failling hard on that case we simply return the message to the user and we continue on any setup task. This commit wrap the minimum error related to dashboard and filesystem using errors.wrap after the beat setup command will inspect any error returned by the import dashboard, if they are of type ErrNotFound we will just display a message to the user and continue with the execution. Fixes: elastic#8949 and elastic#8933 **Notes:** We could do a bit more refactoring to allow the dashboard importer to better communication any hiccups, this was the minimal changes to make it work without adding too much risk. (cherry picked from commit 4e812da)
ph
added a commit
that referenced
this pull request
Nov 7, 2018
#8981) Cherry-pick of PR #8977 to 6.x branch. Original message: Its possible that a beat doesn't have any dashboards, instead of failling hard on that case we simply return the message to the user and we continue on any setup task. This commit wrap the minimum error related to dashboard and filesystem using errors.wrap after the beat setup command will inspect any error returned by the import dashboard, if they are of type ErrNotFound we will just display a message to the user and continue with the execution. Fixes: #8949 and #8933 **Notes:** We could do a bit more refactoring to allow the dashboard importer to better communication any hiccups, this was the minimal changes to make it work without adding too much risk.
ph
added a commit
that referenced
this pull request
Nov 8, 2018
#8982) * Do not fails hard if dashboard are not found (#8977) Its possible that a beat doesn't have any dashboards, instead of failling hard on that case we simply return the message to the user and we continue on any setup task. This commit wrap the minimum error related to dashboard and filesystem using errors.wrap after the beat setup command will inspect any error returned by the import dashboard, if they are of type ErrNotFound we will just display a message to the user and continue with the execution. Fixes: #8949 and #8933 **Notes:** We could do a bit more refactoring to allow the dashboard importer to better communication any hiccups, this was the minimal changes to make it work without adding too much risk. (cherry picked from commit 4e812da) * fix
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ot found (elastic#8982) * Do not fails hard if dashboard are not found (elastic#8977) Its possible that a beat doesn't have any dashboards, instead of failling hard on that case we simply return the message to the user and we continue on any setup task. This commit wrap the minimum error related to dashboard and filesystem using errors.wrap after the beat setup command will inspect any error returned by the import dashboard, if they are of type ErrNotFound we will just display a message to the user and continue with the execution. Fixes: elastic#8949 and elastic#8933 **Notes:** We could do a bit more refactoring to allow the dashboard importer to better communication any hiccups, this was the minimal changes to make it work without adding too much risk. (cherry picked from commit 1775ce9) * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its possible that a beat doesn't have any dashboards, instead of
failling hard on that case we simply return the message to the user and
we continue on any setup task.
This commit wrap the minimum error related to dashboard and filesystem
using errors.wrap after the beat setup command will inspect any error
returned by the import dashboard, if they are of type ErrNotFound we
will just display a message to the user and continue with the execution.
Fixes: #8949 and #8933
Notes: We could do a bit more refactoring to allow the dashboard importer to better communication any hiccups, this was the minimal changes to make it work without adding too much risk.