Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added write and read disk IO times on Metricbeat system module #8508

Merged
merged 5 commits into from
Oct 3, 2018
Merged

Added write and read disk IO times on Metricbeat system module #8508

merged 5 commits into from
Oct 3, 2018

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Oct 1, 2018

Related to #8473 I have added read and write await times using the same formulas and procedures.

I maintained current await field for compatibility too.

@ruflin
Copy link
Contributor

ruflin commented Oct 1, 2018

Nice addition. Could you also add a CHANGELOG and updated the data.json file: https://github.com/elastic/beats/blob/master/metricbeat/module/system/diskio/_meta/data.json This file is normally generated. Let me know if you need some help on where this happens.

@sayden
Copy link
Contributor Author

sayden commented Oct 1, 2018

The error seems unrelated:

======================================================================
ERROR: Test reload same config with same file but different config. Makes sure reloading also works on conflicts.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/go/src/github.com/elastic/beats/filebeat/tests/system/test_reload_inputs.py", line 284, in test_reload_same_config
    max_timeout=15)
  File "/go/src/github.com/elastic/beats/filebeat/tests/system/../../../libbeat/tests/system/beat/beat.py", line 325, in wait_until
    "Waited {} seconds.".format(max_timeout))
TimeoutError: Timeout waiting for 'cond' to be true. Waited 15 seconds.
----------------------------------------------------------------------

@ruflin ruflin added review needs_backport PR is waiting to be backported to other branches. labels Oct 1, 2018
@ruflin
Copy link
Contributor

ruflin commented Oct 1, 2018

jenkins, test this

@ruflin
Copy link
Contributor

ruflin commented Oct 1, 2018

I added the review and needs_backport label as I think it's ready for review and we should also backport it to 6.x.

exekias
exekias approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition @sayden!

@sayden sayden merged commit 7798003 into elastic:master Oct 3, 2018
sayden added a commit to sayden/beats that referenced this pull request Oct 4, 2018
@sayden
Added write and read disk IO times on Metricbeat system module (elast…
25f00b7 
…ic#8508)

Added write and read disk io times on Metricbeat system module

(cherry picked from commit 7798003)
@sayden sayden mentioned this pull request Oct 4, 2018
Merged
@sayden sayden added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 4, 2018
sayden added a commit that referenced this pull request Oct 4, 2018
@sayden
Cherry-pick #8508 to 6.x: Added write and read disk IO times on Metri…
3da9e60 
…cbeat system module (#8565)

Added write and read disk IO times on Metricbeat system module (#8508)
@ruflin ruflin mentioned this pull request Oct 5, 2018
Closed
@anelson-vidscale
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
enhancement Metricbeat Metricbeat module review v6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayden @ruflin @anelson-vidscale @exekias