-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show deprecated fields in documentation #7779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added support in the fields.yml to add a deprecated notice to a field. This is now also shown in the docs. It is important that each field contains the version it was deprecated and not just a bool.
ruflin
force-pushed
the
deprecated-fields-docs
branch
from
July 30, 2018 06:07
6a91bf2
to
aa5fb6b
Compare
jsoriano
approved these changes
Jul 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good addition to have the version the field was deprecated on.
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jul 30, 2018
ruflin
pushed a commit
that referenced
this pull request
Jul 30, 2018
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jul 30, 2018
(cherry picked from commit 32442e5)
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Jul 30, 2018
We recently added support in the fields.yml to add a deprecated notice to a field. This is now also shown in the docs. It is important that each field contains the version it was deprecated and not just a bool. (cherry picked from commit fb0d7d4)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jul 30, 2018
exekias
pushed a commit
that referenced
this pull request
Jul 31, 2018
) * Show deprecated fields in documentation (#7779) We recently added support in the fields.yml to add a deprecated notice to a field. This is now also shown in the docs. It is important that each field contains the version it was deprecated and not just a bool. (cherry picked from commit fb0d7d4) * Remove unneeded print left by mistake in #7779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added support in the fields.yml to add a deprecated notice to a field. This is now also shown in the docs.
It is important that each field contains the version it was deprecated and not just a bool.