Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deprecated fields in documentation #7779

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jul 27, 2018

We recently added support in the fields.yml to add a deprecated notice to a field. This is now also shown in the docs.

It is important that each field contains the version it was deprecated and not just a bool.

We recently added support in the fields.yml to add a deprecated notice to a field. This is now also shown in the docs.

It is important that each field contains the version it was deprecated and not just a bool.
@ruflin ruflin force-pushed the deprecated-fields-docs branch from 6a91bf2 to aa5fb6b Compare July 30, 2018 06:07
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good addition to have the version the field was deprecated on.

@jsoriano jsoriano merged commit fb0d7d4 into elastic:master Jul 30, 2018
jsoriano added a commit to jsoriano/beats that referenced this pull request Jul 30, 2018
jsoriano added a commit to jsoriano/beats that referenced this pull request Jul 30, 2018
jsoriano pushed a commit to jsoriano/beats that referenced this pull request Jul 30, 2018
We recently added support in the fields.yml to add a deprecated notice to a field. This is now also shown in the docs.

It is important that each field contains the version it was deprecated and not just a bool.

(cherry picked from commit fb0d7d4)
jsoriano added a commit to jsoriano/beats that referenced this pull request Jul 30, 2018
exekias pushed a commit that referenced this pull request Jul 31, 2018
)

* Show deprecated fields in documentation (#7779)

We recently added support in the fields.yml to add a deprecated notice to a field. This is now also shown in the docs.

It is important that each field contains the version it was deprecated and not just a bool.

(cherry picked from commit fb0d7d4)

* Remove unneeded print left by mistake in #7779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants