Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Vagrant machines #7153

Merged
merged 2 commits into from
May 24, 2018
Merged

Conversation

andrewkroh
Copy link
Member

This adds a few Linux distros to the Vagrantfile for convenient testing.

  • Ubuntu1804
  • ArchLinux
  • SLES12
  • Centos6
  • Fedora26 -> 27 (update)

This adds a few Linux distros to the Vagrantfile for convenient testing.

- Ubuntu1804
- ArchLinux
- SLES12
- Centos6
- Fedora26 -> 27 (update)
Copy link
Collaborator

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor questions.

Vagrantfile Outdated
c.vm.box = "bento/centos-6.9"
c.vm.network :forwarded_port, guest: 22, host: 2229, id: "ssh", auto_correct: true

#c.vm.provision "shell", inline: $unixProvision, privileged: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you leave these lines in on purpose? Or should it be commented out?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was unintentional. I was testing provisioning and since those steps are not idempotent I comment them out.

It's fixed now.

@ruflin ruflin merged commit e2a320f into elastic:master May 24, 2018
@andrewkroh andrewkroh deleted the vagrantfile-machines branch May 29, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants