Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate: UDP prospector the input interface #6118

Merged
merged 2 commits into from
Feb 1, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Jan 19, 2018

Refactor the input prospector to use the input interface

Require: #6078

@ph ph added in progress Pull request is currently in progress. Filebeat Filebeat labels Jan 19, 2018
@ph ph changed the title Refactor/udp prospector to input Migrate: UDP prospector the input interface Jan 19, 2018
@ph ph mentioned this pull request Jan 19, 2018
10 tasks
@ph ph force-pushed the refactor/type-aliasing-input branch from d027f45 to 0e31dc7 Compare January 22, 2018 18:35
@ph ph force-pushed the refactor/udp-prospector-to-input branch 2 times, most recently from a58d8be to 86262a0 Compare January 23, 2018 02:35
@ph ph changed the base branch from refactor/type-aliasing-input to master January 23, 2018 02:35
@ph ph force-pushed the refactor/udp-prospector-to-input branch from 86262a0 to f210f81 Compare January 23, 2018 02:38
@ph ph added review and removed in progress Pull request is currently in progress. labels Jan 23, 2018
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one minor question.

@@ -10,6 +10,7 @@ type Prospectorer = input.Input

// Runner encapsulate the lifecycle of a prospectorer
// Deprecated: See input.Runner
type Prospector = input.Runner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this related to this change?

@ph ph force-pushed the refactor/udp-prospector-to-input branch 2 times, most recently from 2eda594 to 09c1b8b Compare January 30, 2018 21:07
@ph
Copy link
Contributor Author

ph commented Jan 30, 2018

@ruflin update/rebased.

@ph ph force-pushed the refactor/udp-prospector-to-input branch from 09c1b8b to f130d01 Compare January 31, 2018 14:26
@ruflin ruflin merged commit 67ab782 into elastic:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants