Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS: report handshake latency #5766

Merged
merged 4 commits into from
Nov 30, 2017
Merged

Conversation

adriansr
Copy link
Contributor

  • Time spent between first packet and completion of handshake is reported in the common field responsetime.

  • Histogram visualization added to Kibana dashboard

  • New screen capture for docs

The time it takes for the handshake to complete is saved to
the `responsetime` field.
@@ -343,6 +348,12 @@ func (plugin *tlsPlugin) createEvent(conn *tlsConnectionData) beat.Event {
}
}

// set "responsetime" if handshake completed
responseTime := int32(conn.endTime.Sub(conn.startTime).Nanoseconds() / 1e6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer time.Millisecond instead of 1e6.

@andrewkroh andrewkroh merged commit 898af15 into elastic:master Nov 30, 2017
@adriansr adriansr deleted the tls/latency branch May 22, 2018 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants