Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Golang 1.9.2 #5569

Merged
merged 3 commits into from
Nov 15, 2017
Merged

Update to Golang 1.9.2 #5569

merged 3 commits into from
Nov 15, 2017

Conversation

ruflin
Copy link
Collaborator

@ruflin ruflin commented Nov 13, 2017

No description provided.

@ruflin
Copy link
Collaborator Author

ruflin commented Nov 13, 2017

jenkins, package it

@@ -9,7 +9,7 @@ MAINTAINER Tudor Golubenco <tudor@elastic.co>

# Configure the root Go distribution and bootstrap based on it
RUN \
export ROOT_DIST="https://storage.googleapis.com/golang/go1.8.3.linux-amd64.tar.gz" && \
export ROOT_DIST="https://storage.googleapis.com/golang/go1.9.2.linux-amd64.tar.gz" && \
export ROOT_DIST_SHA1="838c415896ef5ecd395dfabde5e7e6f8ac943c8e" && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure the SHA1 sums need updated too.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. updated both. Also renamed the directory which is called 1.8.3.

@ruflin
Copy link
Collaborator Author

ruflin commented Nov 14, 2017

jenkins, package it

@ruflin
Copy link
Collaborator Author

ruflin commented Nov 14, 2017

Testing packaging locally ...

@ruflin
Copy link
Collaborator Author

ruflin commented Nov 14, 2017

Run the packaging locally and it seems to work as expected.

@ruflin
Copy link
Collaborator Author

ruflin commented Nov 14, 2017

jenkins, test it

@ruflin
Copy link
Collaborator Author

ruflin commented Nov 14, 2017

jenkins, retest it

@ruflin
Copy link
Collaborator Author

ruflin commented Nov 15, 2017

Build currently fails with

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-QaRIki/PyYAML/
../libbeat/scripts/Makefile:209: recipe for target 'python-env' failed

@ruflin
Copy link
Collaborator Author

ruflin commented Nov 15, 2017

jenkins, retest it

Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐹

@exekias exekias merged commit 408af58 into elastic:master Nov 15, 2017
@ruflin ruflin deleted the golang-192 branch November 16, 2017 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants