Cleanup scan config options. Mark it experimental. #4564
Conversation
c923831 to
ca77f32
Compare
|
|
||
| If you specify a value other than none for this setting you can determine whether to use ascending or descending order using `scan.order`. | ||
| Specifies if files should be harvested in order and how to determine the order. Possible values are `modtime`, `filename`. Leaving the option empty means its disabled. To sort by file modification time use modtime otherwise use filename. |
There was a problem hiding this comment.
Starting with the 2nd sentence, change to say:
Possible values are modtime and filename. To sort by file modification time, use modtime, otherwise use filename. Leave this option empty to disable it.
|
|
||
| The default setting is none. | ||
| If you specify a value for this setting you can determine whether to use ascending or descending order using `scan.order`. |
There was a problem hiding this comment.
Change to say: If you specify a value for this setting, you can use scan.order to configure whether files are scanned in ascending or descending order.
| Specifies ascending or descending order if `scan.sort` is set to a value other than none. Possible values are asc or desc. | ||
| []experimental | ||
|
|
||
| Specifies ascending or descending order if `scan.sort` is set to a value other than none. Possible values are `asc` or `desc`. |
There was a problem hiding this comment.
Change to say: Specifies whether to use ascending or descending order when scan.sort is set to a value other than none.
ccc7aca to
5ee8cd4
Compare
|
|
||
| If you specify a value other than none for this setting you can determine whether to use ascending or descending order using `scan.order`. | ||
| If you specify a value other than none for this setting you can determine whether to use ascending or descending order using `scan.order`. Possible values are `modtime` and `filename`. To sort by file modification time, use `modtime`, otherwise use `filename`. Leave this option empty to disable it. |
There was a problem hiding this comment.
"other than none" is confusing here, because it used to be the string "none" and now it's the empty string, right? I suggest "other than the empty string".
Follow up PR from elastic#4374.
5ee8cd4 to
a8f1de4
Compare
Follow up PR from #4374.