Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricbeat] Gather more fields from _node/stats #42421

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[metricbeat] Gather more fields from _node/stats #42421

wants to merge 7 commits into from
+30,010 −11

Conversation

consulthys
Copy link
Contributor

@consulthys consulthys commented Jan 24, 2025 •
edited
Loading

Proposed commit message

This PR modifies the node_stats metric set of the Metricbeat elasticsearch module to gather more fields from the _nodes/stats API. Those additional fields are required to build more useful Stack Monitoring dashboards for support and customers.

Additionally, this PR also makes sure that only the necessary _nodes/stats metrics are retrieved, a necessary enhancement that was filed in #40183 but never went through.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

Related issues

Relates to #42131
Closes #40183

@consulthys consulthys added enhancement Feature:Stack Monitoring Team:Monitoring Stack Monitoring team backport-8.x Automated backport to the 8.x branch with mergify labels Jan 24, 2025
@consulthys consulthys requested a review from a team as a code owner January 24, 2025 15:11
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 24, 2025
@consulthys consulthys self-assigned this Jan 24, 2025
@consulthys consulthys mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@consulthys consulthys

Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Feature:Stack Monitoring Team:Monitoring Stack Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metricbeat] Elasticsearch module should only gather node_stats it needs
1 participant
@consulthys